launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-test-html5browser into launchpad:master.

Commit message:
Fix html5browser tests for Python 3

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/397165
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-test-html5browser into launchpad:master.

diff --git a/lib/lp/testing/tests/test_html5browser.py b/lib/lp/testing/tests/test_html5browser.py
index bdece29..2345e16 100644
--- a/lib/lp/testing/tests/test_html5browser.py
+++ b/lib/lp/testing/tests/test_html5browser.py
@@ -79,7 +79,8 @@ class BrowserTestCase(TestCase):
 
     def setUp(self):
         super(BrowserTestCase, self).setUp()
-        self.file = NamedTemporaryFile(prefix='html5browser_', suffix='.html')
+        self.file = NamedTemporaryFile(
+            mode='w+', prefix='html5browser_', suffix='.html')
         self.addCleanup(self.file.close)
 
     def test_init_default(self):