launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/launchpad:py3-io-security into launchpad:master.

Commit message:
Remove StringIO security declaration

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #5133 in Launchpad itself: "zope3 lacks security declaration for StringIO.StringIO"
  https://bugs.launchpad.net/launchpad/+bug/5133

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/391037

This was rather fiddly to port to Python 3, but it seems to be unused: no tests fail after simply removing it instead.  It seems likely that StringIO is never returned from security-proxied methods.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/launchpad:py3-io-security into launchpad:master.

diff --git a/lib/lp/services/webapp/bug-5133.zcml b/lib/lp/services/webapp/bug-5133.zcml
deleted file mode 100644
index 9e5e048..0000000
--- a/lib/lp/services/webapp/bug-5133.zcml
+++ /dev/null
@@ -1,14 +0,0 @@
-<!-- Copyright 2009 Canonical Ltd.  This software is licensed under the
-     GNU Affero General Public License version 3 (see the file LICENSE).
--->
-
-<configure
-    xmlns="http://namespaces.zope.org/zope";
-    xmlns:i18n="http://namespaces.zope.org/i18n";
-    i18n_domain="launchpad">
-
-    <class class="StringIO.StringIO">
-        <allow attributes="seek getvalue readlines read write writelines" />
-    </class>
-</configure>
-
diff --git a/lib/lp/services/webapp/configure.zcml b/lib/lp/services/webapp/configure.zcml
index bfbb9cb..95f495d 100644
--- a/lib/lp/services/webapp/configure.zcml
+++ b/lib/lp/services/webapp/configure.zcml
@@ -10,7 +10,6 @@
 
     <include file="servers.zcml" />
     <include file="errorlog.zcml" />
-    <include file="bug-5133.zcml" />
 
     <browser:defaultView name="index.html" />