kolibri-discuss team mailing list archive

[Anders Steinlein <anders@xxxxxxxxxxxx>]

While going through the framework hunting for trigger_error()s to be
replaced by exceptions, one thing struck me in XslTransformer as it
relates to XmlGenerator in XsltResult. XslTransformer's addXml() method
currently only accepts XML as a string, which is loaded into a
DOMDocument internally. This seems rather odd considering we use a
DOMDucument internally in XmlGenerator as well, before it is dumped to a
string. I suggest this should be improved during the current rewrite of
XmlGenerator, to support, say, buildToDom() and buildToString(), with
matching methods in XslTransformer.

-- 
Regards,
 \Anders