← Back to team overview

kolibri-discuss team mailing list archive

Thread
Date

Re: Proposed merge of lp:~asteinlein/kolibri/remove-exposable into lp:kolibri

To: Kolibri Discuss <kolibri-discuss@xxxxxxxxxxxxxxxxxxx>
From: Frode Danielsen <frode@xxxxxxx>
Date: Wed, 10 Dec 2008 11:45:03 -0000
In-reply-to: <20081210020959.2938.32793.launchpad@gangotri.canonical.com>
Reply-to: mp+2240@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Vote: Approve
Looks good! No traces of the Exposable interface, and obsolete expose() methods are gone. I like the transition to relying on object iteration instead of the old get_object_vars(), which works perfectly for Session.
-- 
https://code.launchpad.net/~asteinlein/kolibri/remove-exposable/+merge/2240
You are subscribed to branch lp:kolibri.

References

Proposed merge of lp:~asteinlein/kolibri/remove-exposable into lp:kolibri
From: Anders Steinlein, 2008-12-10