kolibri-discuss team mailing list archive

Thread
Date

Re: Proposed merge of lp:~asteinlein/kolibri/db-cleanup into lp:kolibri

To: Kolibri Discuss <kolibri-discuss@xxxxxxxxxxxxxxxxxxx>
From: Frode Danielsen <frode@xxxxxxx>
Date: Fri, 05 Dec 2008 02:22:37 -0000
In-reply-to: <20081204202314.29578.30413.launchpad@gandwana.canonical.com>
Reply-to: mp+2142@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Vote: Approve
DatabaseFactory got a nice brushup, I like the use of class_exists() instead of trying to require the class files every time.

I guess I should've read up on object iteration before complaining about valid() ;-) It just didn't cross my mind to be relevant to iteration, as opposed to next(), rewind() etc.

Everything I discovered is fixed/improved, and I think this overall improvement to Kolibri's database support is ready for action!
-- 
https://code.launchpad.net/~asteinlein/kolibri/db-cleanup/+merge/2142
You are subscribed to branch lp:kolibri.