kolibri-discuss team mailing list archive

[Frode Danielsen <frode@xxxxxxxxxxxxx>]

Good feedback. All suggested improvements have been implemented in  
SmartyResult and PhpResult. I've also given read access to the  
application configuration for both SmartyResult and PhpResult -  
similar to how XsltResult makes scalar variables available, but both  
Smarty and Php supports arrays as well of course.

These recent improvements have also been pushed to the public mirror,  
ready for merging.

Regards,
--
Frode

On Dec 3, 2008, at 4:57 PM, Anders Steinlein wrote:

> I've had a quick look at SmartyResult and PhpResult in their  
> respective
> branches, and they look ready to be merged into trunk soon.  
> PhpResult in
> particular looks ready to go, aside from the render() comment which
> should be updated now that the request is exposed as the object it is.
>
> SmartyResult should be changed to expose the request directly as has
> been done with PhpResult. I also suggest updating the class comment to
> include a complete example of configuration instead of "explaining it"
> in text. I.e. something like:
>
>   'smarty' => array(
>     'compileDir' => '' // Full path to PHP-writable directory
>     'cacheDir'   => '' // ...
>     ...
>
> After that, I think they're both pretty good to go.
>
> Regards,
> \Anders
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kolibri-discuss
> Post to     : kolibri-discuss@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kolibri-discuss
> More help   : https://help.launchpad.net/ListHelp