fema-team team mailing list archive

[Themiya Jayasinghe <themiya.jayasinghe@xxxxxxxxx>]

Hi James,

1. The DefaultOptions class will contain a protected member of type Options
?

2. How do we handle unsigned types ? Do we need things like
Options.getUnsignedInteger(...)

3  In the DefaultOptions class, store the maxIterationCount in a private
member like how you did for maxArchiveSize in PAESOptions.
( Otherwise you would need to pass the default value to
_options.getInteger(...) in getMaxIterationCount() )

i.e. change

<<class>> *DefaultOptions*
DefaultOptions(Options options)
int getMaxIterationCount() { _options.getInteger("max_iteration_count", *???
*); }

to

<<class>> *DefaultOptions*
size_t _maxIterationCount
DefaultOptions(Options options) : _options(options) {

_maxIterationCount = _options->getUnsignedInteger("max_iteration_count",
10000000);

}
size_t getMaxIterationCount() { return _maxIterationCount; }

4 . Maybe rename Options to OptionsContainer or something like that ? Also,
rename DefaultOptions to Options ?

-jt

P.S. Will you be coming to Uni today or tomorrow ?