evoteam team mailing list archive

[Daniel Hahler <launchpad@xxxxxxxxxx>]

I think "0" is meant for "no limit", but NULL means "take whatever makes
sense".

Do you agree?

** Changed in: b2evolution
       Status: New => Incomplete

** Changed in: b2evolution
   Importance: Undecided => Low

-- 
ItemListLight with a NULL limit doesn't return a unlimited query
https://bugs.launchpad.net/bugs/422352
You received this bug notification because you are a member of Evoteam,
which is subscribed to b2evolution.

Status in b2evolution: Incomplete

Bug description:
I tought that using a ItemListLight with a NULL limit would issue a query with no SQL LIMIT clause.

But, ItemListLight inherits from DataObjectList2, that extends Results, that have a line like this:

		$this->limit = is_null($limit) ? $UserSettings->get('results_per_page') : $limit;

To users that are not logged in, the limit is 20, that is setterd in the ItemListLight itself, even if $limit on constructor is null.

Is this a bug? To me, a ItemListLight with a NULL limit should have... no limit :)