debcrafters-packages team mailing list archive

[Antoine Lassagne <2127792@xxxxxxxxxxxxxxxxxx>]

Hello,

- The protocol should be RDP - Remote Desktop Protocol. Indeed in Gnome
settings panel it's called Remote Login.

- No additional chmod's should be required. But there is actually
another bug somewhat close that you're involved in already
(https://bugs.launchpad.net/ubuntu/+source/gnome-remote-
desktop/+bug/2077538?comments=all). Because of this one (I think) we
have to add the user we setup in the "Remote Login" to both the video
and render groups, otherwise it crashes. What do you think?

- The monitor: actually this fix is about headless sessions. But testing
with AND without a monitor would be safer. Adding to the test plan.

- The negociation: this is what I implied when I mentioned that the
backend should use NVENC. Reminna Snap uses NVENC, the .deb does not.
Adding these details in the test plan.

** Description changed:

  There is image distorsion in gnome-remote-desktop when a Blackwell GPU
  is in use and NVENC is responsible for the video streaming.
  
  Upstream issue: https://gitlab.gnome.org/GNOME/gnome-remote-
  desktop/-/issues/263
  
  A fix was just released by nvidia upstream, and also backported to GNOME 48: https://gitlab.gnome.org/GNOME/gnome-remote-desktop/-/merge_requests/344
  https://gitlab.gnome.org/GNOME/gnome-remote-desktop/-/merge_requests/346
  
  ---------------------------
  SRU Justification:
  
  [ Impact ]
  
-  * This is a hardware enablement SRU.
+  * This is a hardware enablement SRU.
  
-  * gnome-remote-desktop, when used alongside NVENC for video streaming,
+  * gnome-remote-desktop, when used alongside NVENC for video streaming,
  simply does not work, because the image is broken.
  
-  * With the above, the streaming is fixed.
+  * With the above, the streaming is fixed.
  
  [ Fix ]
  
-  * Nvidia devices never supported `NV_ENC_PARAMS_FRAME_FIELD_MODE_MBAFF`.
+  * Nvidia devices never supported `NV_ENC_PARAMS_FRAME_FIELD_MODE_MBAFF`.
  Though the code worked for past, it causes interlaced line artifacts on
  Blackwell GPUs.
  
  * Using `NV_ENC_PARAMS_FRAME_FIELD_MODE_FRAME` and changing
  `grd-cuda-avc-utils` to produce progressive frames works on
  Blackwell and on older GPU generations.
  
  [ Test Plan ]
  
-  * Test gnome-remote-desktop with and without the fix. Make sure which
+ 1. Use a DUT that has a Blackwell GPU
+ (https://en.wikipedia.org/wiki/Blackwell_(microarchitecture)#Blackwell_dies)
+ 
+ 2. Enable Remote Login from the Gnome Settings on the DUT with a monitor
+ plugged in.
+ 
+ 3. Install Reminna from Snap. This version supports NVENC, the .deb does
+ not.
+ 
+ 4. Test gnome-remote-desktop with and without the fix. Make sure which
  backend is in use. This can be checked by running `nvidia-smi dmon` and
  observing an encoder activity >0%. The repro only occurs when the NVENC
  path is used. CPU encoding path or non-H264 streaming is unaffected
  
- * Run the same test on an older GPU generation (Maxwell, ideally)
+ 5. Run the same test without a monitor plugged in to the DUT.
  
+ 6. Run the same tests (with and without monitors) on an older GPU
+ generation (Maxwell, ideally)
  
  [ Where problems could occur ]
  
-  * Given the nature of the fix, it should not impact non-nvidia machines.
-  * Also, the  fix comes from nvidia themsleves, and it's in GNOME 48 and 49 already, so it's pretty safe.
+  * Given the nature of the fix, it should not impact non-nvidia machines.
+  * Also, the  fix comes from nvidia themsleves, and it's in GNOME 48 and 49 already, so it's pretty safe.

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to gnome-remote-desktop in
Ubuntu.
https://bugs.launchpad.net/bugs/2127792

Title:
  Images are corrupted on blackwell GPUs

Status in gnome-remote-desktop package in Ubuntu:
  Fix Released
Status in gnome-remote-desktop source package in Noble:
  In Progress
Status in gnome-remote-desktop source package in Plucky:
  In Progress
Status in gnome-remote-desktop source package in Questing:
  In Progress
Status in gnome-remote-desktop source package in Resolute:
  Fix Released

Bug description:
  There is image distorsion in gnome-remote-desktop when a Blackwell GPU
  is in use and NVENC is responsible for the video streaming.

  Upstream issue: https://gitlab.gnome.org/GNOME/gnome-remote-
  desktop/-/issues/263

  A fix was just released by nvidia upstream, and also backported to GNOME 48: https://gitlab.gnome.org/GNOME/gnome-remote-desktop/-/merge_requests/344
  https://gitlab.gnome.org/GNOME/gnome-remote-desktop/-/merge_requests/346

  ---------------------------
  SRU Justification:

  [ Impact ]

   * This is a hardware enablement SRU.

   * gnome-remote-desktop, when used alongside NVENC for video
  streaming, simply does not work, because the image is broken.

   * With the above, the streaming is fixed.

  [ Fix ]

   * Nvidia devices never supported `NV_ENC_PARAMS_FRAME_FIELD_MODE_MBAFF`.
  Though the code worked for past, it causes interlaced line artifacts on
  Blackwell GPUs.

  * Using `NV_ENC_PARAMS_FRAME_FIELD_MODE_FRAME` and changing
  `grd-cuda-avc-utils` to produce progressive frames works on
  Blackwell and on older GPU generations.

  [ Test Plan ]

  1. Use a DUT that has a Blackwell GPU
  (https://en.wikipedia.org/wiki/Blackwell_(microarchitecture)#Blackwell_dies)

  2. Enable Remote Login from the Gnome Settings on the DUT with a
  monitor plugged in.

  3. Install Reminna from Snap. This version supports NVENC, the .deb
  does not.

  4. Test gnome-remote-desktop with and without the fix. Make sure which
  backend is in use. This can be checked by running `nvidia-smi dmon`
  and observing an encoder activity >0%. The repro only occurs when the
  NVENC path is used. CPU encoding path or non-H264 streaming is
  unaffected

  5. Run the same test without a monitor plugged in to the DUT.

  6. Run the same tests (with and without monitors) on an older GPU
  generation (Maxwell, ideally)

  [ Where problems could occur ]

   * Given the nature of the fix, it should not impact non-nvidia machines.
   * Also, the  fix comes from nvidia themsleves, and it's in GNOME 48 and 49 already, so it's pretty safe.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-remote-desktop/+bug/2127792/+subscriptions