← Back to team overview

debcrafters-packages team mailing list archive

[Bug 2127925] Re: "policy: auto-activating connection" never occurs on adapter restart for networks where user entered incorrect password before correct password

 

** Merge proposal linked:
   https://code.launchpad.net/~antoinelassagne/ubuntu/+source/network-manager/+git/network-manager/+merge/494528

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to network-manager in Ubuntu.
https://bugs.launchpad.net/bugs/2127925

Title:
  "policy: auto-activating connection" never occurs on adapter restart
  for networks where user entered incorrect password before correct
  password

Status in network-manager package in Ubuntu:
  New

Bug description:
  This bug was reported upstream:
  https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/1812

  And it got fixed with
  https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/2295

  ---------------------------
  SRU Justification:

  [ Impact ]

   * When trying to connect to a wifi network, if one does cancel the
  credential popup, the network is gets an internal in-memory flag
  preventing its auto reconnection. If then the user succeeds to connect
  to it, this flag is not removed. As a result, if the user disable and
  re-enables wifi, the network will not reconnect automatically.

   * With the above, the reconnection is fixed.

  [ Fix ]

   * Whenever the connection succeeds, the autoconnect blocker flag must
  be removed and reset correctly.

  [ Test Plan ]

   * Test network-manager without and with this fix:
  1. Forget all wifi networks
  2. Click on one on the gnome menubar
  3. Cancel the popup without entering credentials
  4. Check NM's logs to see if an autoconnection is attempted. No autoconnection should be attempted at this point.
  5. Click on this same network again, connect successfully.
  6. Disable and re-enable wifi.
  7. See if an automatic reconnection occurs.

  [ Where problems could occur ]

   * Given the nature of the fix (it's one line), I don't see how
  anything could go wrong here, given we properly run the test plan.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/2127925/+subscriptions



References