datafinder-team team mailing list archive

[Glyphobet <matt-ubuntu@xxxxxxxxxx>]

Glyphobet has proposed merging lp:~glyphobet/python-webdav-lib/default into lp:python-webdav-lib.

Requested reviews:
  DataFinderTeam (datafinder-team)

For more details, see:
https://code.launchpad.net/~glyphobet/python-webdav-lib/default/+merge/149161

sys.stdout always has an encoding attribute, unless it has been overridden with another object, as nosetests does, for example. In that case, sys.stdout.encoding will raise an AttributeError. This will make it not raise that error and fall back to 'ascii'.
-- 
https://code.launchpad.net/~glyphobet/python-webdav-lib/default/+merge/149161
Your team DataFinderTeam is requested to review the proposed merge of lp:~glyphobet/python-webdav-lib/default into lp:python-webdav-lib.

=== modified file 'src/webdav/WebdavResponse.py'
--- src/webdav/WebdavResponse.py	2012-12-14 23:08:04 +0000
+++ src/webdav/WebdavResponse.py	2013-02-18 21:30:32 +0000
@@ -110,7 +110,7 @@
                     key, len(value), ", ".join([prop[1] for prop in value.keys()]), value.errorCount)
             else:
                 result += "Resource at %s returned " % key + unicode(value)
-        return result.encode(sys.stdout.encoding or "ascii", "replace")
+        return result.encode(getattr(sys.stdout, "encoding", "ascii"), "replace")
     
     def _scan(self, root):
         for child in root.children: