curtin-dev team mailing list archive

[Dan Bungert <mp+494693@xxxxxxxxxxxxxxxxxx>]

Review: Approve

Thanks for following up on this, Olivier.  This looked like more change than it really was, with several code moves here.  I found it easier to review commit-by-commit.

Further, the biggest new chunk was dracut scripting, so I'm not sure I have much to say there other than to just confirm that this has seen some sort of VM testing, correct?

One note.

Diff comments:

> diff --git a/curtin/nvme_tcp.py b/curtin/nvme_tcp.py
> index b7cfdc5..a285e09 100644
> --- a/curtin/nvme_tcp.py
> +++ b/curtin/nvme_tcp.py
> @@ -404,3 +493,26 @@ def dracut_adapt_netplan_config(cfg, *, target: pathlib.Path):
>  
>      if modified:
>          netplan_conf_path.write_text(yaml.dump(config))
> +
> +
> +def prevent_initramfs_tools_reinstallation(target: pathlib.Path) -> None:
> +    '''Ensure that initramfs-tools does not get reinstalled over dracut, using
> +    APT pinning.'''
> +    # intel-microcode on 24.04 (pulled by linux-generic) is known to have
> +    # initramfs-tools as a recommends. LP: #2073125
> +    preferences_d = target / 'etc/apt/preferences.d'
> +    preferences_d.mkdir(parents=True, exist_ok=True)
> +    (preferences_d / 'nvmeotcp-poc-initramfs').write_text('''\
> +# The NVMe/TCP proof of concept on Ubuntu uses dracut instead of
> +# initramfs-tools.
> +# That said, dracut is a universe package and is not the supported tool for

does this text need an update?

> +# initramfs management. Installing packages that explicitly depend on
> +# initramfs-tools will cause dracut to be removed, making the system unable to
> +# boot. Furthermore, installing packages that have initramfs-tools as a
> +# recommends can also trigger removal of dracut. Let's make sure
> +# initramfs-tools does not get installed. See LP: #2073125.
> +
> +Package: initramfs-tools
> +Pin: version *
> +Pin-Priority: -1
> +''')


-- 
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/494693
Your team curtin developers is subscribed to branch curtin:master.