← Back to team overview

clearcorp team mailing list archive

[Branch ~banking-addons-team/banking-addons/6.1] Rev 163: [FIX] on_change overwrites IBAN with BBAN

 

Merge authors:
  Stefan Rijnhart (Therp) (stefan-therp)
Related merge proposals:
  https://code.launchpad.net/~therp-nl/banking-addons/ba61-lp1131200-do_not_overwrite_iban_with_bban/+merge/154489
  proposed by: Stefan Rijnhart (Therp) (stefan-therp)
  review: Approve - Guewen Baconnier @ Camptocamp (gbaconnier-c2c)
  review: Approve - Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)
------------------------------------------------------------
revno: 163 [merge]
author: Stefan Rijnhart <stefan@xxxxxxxx>
committer: Guewen Baconnier <guewen.baconnier@xxxxxxxxxxxxxx>
branch nick: banking-addons
timestamp: Tue 2013-04-02 13:34:40 +0200
message:
  [FIX] on_change overwrites IBAN with BBAN
modified:
  account_banking/account_banking.py


--
lp:banking-addons
https://code.launchpad.net/~banking-addons-team/banking-addons/6.1

Your team CLEARCORP development team is subscribed to branch lp:banking-addons.
To unsubscribe from this branch go to https://code.launchpad.net/~banking-addons-team/banking-addons/6.1/+edit-subscription
=== modified file 'account_banking/account_banking.py'
--- account_banking/account_banking.py	2013-01-30 11:34:58 +0000
+++ account_banking/account_banking.py	2013-03-20 19:25:57 +0000
@@ -1520,16 +1520,13 @@
                 if country.code in sepa.IBAN.countries:
                     acc_number_fmt = sepa.BBAN(acc_number, country.code)
                     if acc_number_fmt.valid:
-                        values['acc_number'] = str(acc_number_fmt)
+                        values['acc_number_domestic'] = str(acc_number_fmt)
                     else:
-                        values['acc_number'] = acc_number
                         result.update(warning(
                             _('Invalid format'),
                             _('The account number has the wrong format for %(country)s')
                             % {'country': country.name}
                         ))
-                else:
-                    values['acc_number'] = acc_number
         return result
 
     def onchange_iban(