canonical-ci-engineering team mailing list archive

[Francis Ginther <francis.ginther@xxxxxxxxxxxxx>]

I also see the need for this. We now have a handful of methods laying
around that do things very well.

On Tue, Mar 31, 2015 at 7:56 AM, Evan Dandrea <evan.dandrea@xxxxxxxxxxxxx>
wrote:

>
>
> On 31 March 2015 at 00:27, Thomi Richards <thomi.richards@xxxxxxxxxxxxx>
> wrote:
>>
>> What makes it into the library (acceptance criteria):
>>
>> * Must be backwards compatible. Our services are depending on this, so
>> breaking changes won't be allowed.
>>
>
> Or if it's going to break the API, expose it as a new, versioned method
> instead.
>

Let's be sure to document a pattern for doing this in the developer
playbook. We'll need to define some criteria for when a method is in
development mode and can be changed vs make a new one. This is probably
easy enough to define as when a service begins it's life as a production
service.


> We'll have to be super careful to watch out for not just API breakage in
> MPs, but changes in behaviour. Anything that so alters a method should
> really be a separate one.
>
> * Must be reasonably well tested.
>>
>
> +1
>
>
>> * Must not contain ci-specific logic. This is *not* where we store common
>> data payloads between services (that's a separate library that exists on a
>> per-sprint basis).
>>
>
> A big +1. Let's take a really small slice to try as a library.
>

>>
> How do we publish & use this?
>>
>> I propose that we include it in our pip cache for each service. Whether
>> we actually publish it to pypi or not is open for debate (I don't really
>> mind, I guess I'm leaning slightly towards publishing it, since it may be
>> useful for others).
>>
>
> I honestly don't care, but I don't think we should make a big effort
> around creating a proper project with releases.
>

A dedicated lp project and inserting this into our pip cache(s) sounds like
the right place to begin. Publishing to pypi might make it a little easier
to develop against if we automate the uploads, but I can see deferring this
until we have a clearer usage.

Francis


>
> --
> Mailing list: https://launchpad.net/~canonical-ci-engineering
> Post to     : canonical-ci-engineering@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~canonical-ci-engineering
> More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Francis Ginther
Canonical - Ubuntu Engineering - Continuous Integration Team