← Back to team overview

canonical-ci-engineering team mailing list archive

Re: 3 part MP

 

>>>>> Andy Doan <andy.doan@xxxxxxxxxxxxx> writes:

    > Hey Guys,
    > I started off today wanting something simple:


    > <https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/unit-config-as-template/+merge/204571>

    > This wound up requiring some lower level changes to our deploy/test
    > scripts. So I've done:

    > <https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/deploy-scripts-part1/+merge/204566>
    > <https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/deploy-scripts-part2/+merge/204568>

    > to help put the pieces in place.

    > thought that might provide more context to the changes as you read them.

Nicely laid out, making the third one a pleasant reading ;)

I approved them all with a few nits, feel free to address them in
another proposal if you agree.

        Vincent


References