avanzosc team mailing list archive

["Daniel Campos \(Avanzosc\)" <danielcampos@xxxxxxxxxxx>]

Daniel Campos (Avanzosc) has proposed merging lp:~avanzosc/openerp-spain/6.1 into lp:openerp-spain/6.1.

Requested reviews:
  OpenERP Spain Team (openerp-spain-team)

For more details, see:
https://code.launchpad.net/~avanzosc/openerp-spain/6.1/+merge/206207

Creo que hay un fallo a la hora de calcular el informe cuando el receivable_partner_record es False, ya que se tiene que cumplir la otra parte de la condición para que genere un nuevo mod347.partner_record, de lo contrario se ejecuta el else y da error ya que el id es nulo. En este caso creo que debería cualquiera de las dos condiciones del if para que se generé un nuevo mod347.partner_record.

-- 
https://code.launchpad.net/~avanzosc/openerp-spain/6.1/+merge/206207
Your team Avanzosc Developers is subscribed to branch lp:~avanzosc/openerp-spain/6.1.

=== modified file 'l10n_es_aeat_mod347/wizard/calculate_mod347_records.py'
--- l10n_es_aeat_mod347/wizard/calculate_mod347_records.py	2013-07-18 16:08:37 +0000
+++ l10n_es_aeat_mod347/wizard/calculate_mod347_records.py	2014-02-13 15:39:35 +0000
@@ -263,7 +263,7 @@
                                 receivable_amount = 0.0
                                 receivable_amount = sum([line.credit for line in cash_moves[record]])
                                 if receivable_amount > report_obj.received_cash_limit:
-                                    if record != str(report_obj.fiscalyear_id.id) and receivable_partner_record:
+                                    if record != str(report_obj.fiscalyear_id.id) or not receivable_partner_record:
                                         #create partner record for cash operation in different year to currently
                                         cash_partner_record = self.pool.get('l10n.es.aeat.mod347.partner_record').create(cr, uid, {
                                                 'report_id': report_obj.id ,