← Back to team overview

avanzosc team mailing list archive

Re: [Merge] lp:~xclude/avanzosc/mrp-6.1-Fix into lp:avanzosc/mrp-6.1

 

> Hello, there are some changes you have to do in your code:
> 
> mrp_analytics_control/wizard/mrp_analytic_schema_wizard.py
> 
> Line 48-53 : Duplicated code
> Line 75: Try to use auxiliar variables like is now. I marked this but there
> are more along your code, so if you can fix all will be great.
> 
> The rest of the code looks fine.
> 
> Thanks for your work!

Line 48-53: Corrected method name to get_default_journal. Code isn't duplicate.

-- 
https://code.launchpad.net/~xclude/avanzosc/mrp-6.1-Fix/+merge/190133
Your team Avanzosc Manufacturing team is requested to review the proposed merge of lp:~xclude/avanzosc/mrp-6.1-Fix into lp:avanzosc/mrp-6.1.


References